[webkit-reviews] review granted: [Bug 28084] KURL ref() methods should be fragmentIdentifier() methods : [Attachment 34327] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 7 14:45:27 PDT 2009
Darin Adler <darin at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 28084: KURL ref() methods should be fragmentIdentifier() methods
https://bugs.webkit.org/show_bug.cgi?id=28084
Attachment 34327: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=34327&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> - const KURL& url = this->url();
> - return url.ref().isEmpty() ? "" : "#" + url.ref();
> + const String& fragmentIdentifier = this->url().fragmentIdentifier();
> + return fragmentIdentifier.isEmpty() ? "" : "#" + fragmentIdentifier;
No need for the this-> any more here.
r=me
More information about the webkit-reviews
mailing list