[webkit-reviews] review denied: [Bug 28080] Adding a bunch of Haiku-specific files for WebCore. : [Attachment 34322] Patch to add two Haiku-specific files for WebCore: SharedTimerHaiku.h and SharedTimerHaiku.cpp

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 28080: Adding a bunch of Haiku-specific files for WebCore.
https://bugs.webkit.org/show_bug.cgi?id=28080

Attachment 34322: Patch to add two Haiku-specific files for WebCore:
SharedTimerHaiku.h and SharedTimerHaiku.cpp
https://bugs.webkit.org/attachment.cgi?id=34322&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
We prefer constants over defines:
 38 #define FIRE_MESSAGE 'fire'

What does "sleepyTime" mean?
 67	    bigtime_t sleepyTime = static_cast<bigtime_t>((m_fireTime -
WTF::currentTime()) * 1000000);

bigtime_t sleepTimeInSeconds would be a better name?


This needs a comment:
69	   if (sleepyTime < 0)
 70		sleepyTime = 0;

// If the fire time has already passed, fire immediately.
or similar.

Style:
91     BLooper *looper = BLooper::LooperForThread(find_thread(0));

Otherwise this looks sane enough.  You might want to post the new patch on a
new bug, since the other patches were approved.