[webkit-reviews] review granted: [Bug 28074] V8 bindings for DOMApplicationCache : [Attachment 34295] v8bindings

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Michael Nordman
<michaeln at google.com>'s request for review:
Bug 28074: V8 bindings for DOMApplicationCache
https://bugs.webkit.org/show_bug.cgi?id=28074

Attachment 34295: v8bindings
https://bugs.webkit.org/attachment.cgi?id=34295&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
> -// A JS object of type EventTarget can only be the following possible types:

> -// 1) EventTargetNode; 2) DOMWindow 3) XMLHttpRequest; 4) MessagePort;
> -// 5) XMLHttpRequestUpload
> -// check EventTarget.h for new type conversion methods
> +// A JS object of type EventTarget is limited to a small number of possible
classes.
> +// Check EventTarget.h for new type conversion methods

Heh, good call on this one :)

r=me.