[webkit-reviews] review granted: [Bug 28080] Adding a bunch of Haiku-specific files for WebCore. : [Attachment 34319] Patch to add four Haiku-specific files for WebCore: PopupMenuHaiku.cpp, ScreenHaiku.cpp, SearchPopupMenuHaiku.cpp and SoundHaiku.cpp

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 28080: Adding a bunch of Haiku-specific files for WebCore.
https://bugs.webkit.org/show_bug.cgi?id=28080

Attachment 34319: Patch to add four Haiku-specific files for WebCore:
PopupMenuHaiku.cpp, ScreenHaiku.cpp, SearchPopupMenuHaiku.cpp and
SoundHaiku.cpp
https://bugs.webkit.org/attachment.cgi?id=34319&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
In general "cs" is not a good variable name.  Please refer to the webkit style
guidelines for variable naming.

 62	color_space cs = screen.ColorSpace();

This looks OK though, and not worth another round of review for just that.

Thank you for splitting these up, it makes reviewing *much* easier. :) (and
much less waiting time for you).