[webkit-reviews] review requested: [Bug 24887] Wrong filename when dragging an image to the Desktop. : [Attachment 34290] patch, responding to Darin's review

[bugzilla-daemon at webkit.org]

Jens Alfke <snej at chromium.org> has asked  for review:
Bug 24887: Wrong filename when dragging an image to the Desktop.
https://bugs.webkit.org/show_bug.cgi?id=24887

Attachment 34290: patch, responding to Darin's review
https://bugs.webkit.org/attachment.cgi?id=34290&action=review

------- Additional Comments from Jens Alfke <snej at chromium.org>
This addresses the points made in Darin's review.
In particular, imageToMarkup() now escapes both double-quotes and ampersands,
in all attributes including src.
Also, I had doubts about the HFS+ filename limits, so I looked them up and
found it's actually 255 Unicode characters, not bytes. (I think I was
mis-remembering an old thread on macosx-dev-internal; the UTF-8 limit might be
in ext3.)