[webkit-reviews] review denied: [Bug 27716] Add Geolocation layout tests. : [Attachment 34280] Patch 3 for bug 27716

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 7 10:25:40 PDT 2009


Eric Seidel <eric at webkit.org> has denied steveblock at google.com's request for
review:
Bug 27716: Add Geolocation layout tests.
https://bugs.webkit.org/show_bug.cgi?id=27716

Attachment 34280: Patch 3 for bug 27716
https://bugs.webkit.org/attachment.cgi?id=34280&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This really should be a one of the new-style JS tests.	see fast/js/resources
and make-js-test-wrappers.

That would give you shouldBe(), and debug(), etc. for free.

It looks like someone has duplicated at least part of that functionality with
the "utils.js" file.


More information about the webkit-reviews mailing list