[webkit-reviews] review denied: [Bug 9589] WCSS: -wap-accesskey not supported : [Attachment 34197] resubmit the patch with a more descriptive ChangeLog following the review comments

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied George Staikos <staikos at kde.org>'s
request for review:
Bug 9589: WCSS: -wap-accesskey not supported
https://bugs.webkit.org/show_bug.cgi?id=9589

Attachment 34197: resubmit the patch with a more descriptive ChangeLog
following the review comments	 
https://bugs.webkit.org/attachment.cgi?id=34197&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Changes like these should be explained in the ChangeLog or in the source:
 #if ENABLE(WCSS)
 1068	  mutable HashMap<String, Element*, CaseFoldingHash>
m_elementsByAccessKey;
 1069 #else
10671070     mutable HashMap<StringImpl*, Element*, CaseFoldingHash>
m_elementsByAccessKey;
 1071 #endif

I don't see how this is changed from the last patch I r-d.  I didn't just r-
this because I disagree with WAP. ;)  I r- this because it's difficult to r+
without more information as to what's going on here.

If we're adding a parser, why don't we have parser tests for this?