[webkit-reviews] review denied: [Bug 25401] <use> of text not displayed unless declared after : [Attachment 33019] More efificent

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 7 09:27:55 PDT 2009

Eric Seidel <eric at webkit.org> has denied Rob Buis <rwlbuis at gmail.com>'s request
for review:
Bug 25401: <use> of text not displayed unless declared after

Attachment 33019: More efificent

------- Additional Comments from Eric Seidel <eric at webkit.org>
Please make your test dumpAsText, no need to use a full rendering test.

Why shouldn't this just be on SVGElement:
134 void SVGTextElement::childrenChanged(bool changedByParser, Node*
beforeChange, Node* afterChange, int childCountDelta)
 135 {
 136	 SVGElement::childrenChanged(changedByParser, beforeChange,
afterChange, childCountDelta);
 138	 // Invalidate all SVGElementInstances associated with us
 139	 SVGElementInstance::invalidateAllInstancesOfElement(this);
 140 }

How do non-text nodes get around needing to make this call to update <use>

More information about the webkit-reviews mailing list