[webkit-reviews] review denied: [Bug 25406] -webkit-box-orient:horizontal doesn't work on <button> tag : [Attachment 32520] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 7 09:32:00 PDT 2009

Eric Seidel <eric at webkit.org> has denied Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 25406: -webkit-box-orient:horizontal doesn't work on <button> tag

Attachment 32520: Patch v2

------- Additional Comments from Eric Seidel <eric at webkit.org>
In general this looks fine.

Is it possible to make a dumpAsText test for this instead?

Should "isBox" be isFlexibleBox?

Why shouldn't this check be moved inside createAnonymousBlock?
 55	    bool isBox = style()->display() == BOX || style()->display() ==

r- for now, pending comments.  Feel free to set it back to r=? when you answer!

More information about the webkit-reviews mailing list