[webkit-reviews] review denied: [Bug 24300] Add CSSKeepVisitedLinksPrivate option to WebCore : [Attachment 32098] Updated patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied robert <robert at roberthogan.net>'s
request for review:
Bug 24300: Add CSSKeepVisitedLinksPrivate option to WebCore
https://bugs.webkit.org/show_bug.cgi?id=24300

Attachment 32098: Updated patch
https://bugs.webkit.org/attachment.cgi?id=32098&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I thought the QWebHistoryInterface interface was deprecated?  I know that
WebKit qt has some hacks in place around the WebCore link hashing system just
to support this interface.  Seeems we should not be using it from DRT if
something better is available.

Style:
 92	DRTHistory *historyManager;

Leaked:
 154	 historyManager = new DRTHistory(m_page);

You tests shoudl ideally e dumpAsText, since all they need to do is check the
computedStyle, they don't need to dump the pixels for the page to confirm this
change.