[webkit-reviews] review granted: [Bug 21818] Should be able to use AtomicString as the key for a HashMap and HashSet : [Attachment 24622] Patch, changelog

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 23 16:04:04 PDT 2008


Darin Adler <darin at apple.com> has granted Simon Fraser
<simon.fraser at apple.com>'s request for review:
Bug 21818: Should be able to use AtomicString as the key for a HashMap and
HashSet
https://bugs.webkit.org/show_bug.cgi?id=21818

Attachment 24622: Patch, changelog
https://bugs.webkit.org/attachment.cgi?id=24622&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
> +    unsigned existingHash() const { return m_hash; }

You need an ASSERT(m_hash) in here.

How did you test?

r=me


More information about the webkit-reviews mailing list