[webkit-reviews] review denied: [Bug 21841] GraphicsContextCG uses CFURLRef conversions that may not be available : [Attachment 24623] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Mark Mentovai <mark at moxienet.com>'s
request for review:
Bug 21841: GraphicsContextCG uses CFURLRef conversions that may not be
available
https://bugs.webkit.org/show_bug.cgi?id=21841

Attachment 24623: Patch
https://bugs.webkit.org/attachment.cgi?id=24623&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
A better way to handle this is would be to put the notImplemented() call inside
the GOOGLEURL version of CFURLRef. There's no good reason that KURL when
PLATFORM(CF) is true shouldn't implement conversion to a CFURL, regardless of
whether it's based on the Google URL library; putting the workaround for that
in the GraphicsContext file seems wrong.

> +#if PLATFORM(CF) && !USE(GOOGLEURL)

The !USE(GOOGLEURL) part is fine, but the PLATFORM(CF) check here is
unnecessary and should be removed. CoreGraphics is built on top of
CoreFoundation. You can't compile GraphicsContextCG.cpp if PLATFORM(CF) is
false.

I'm going to say review- because I think this check is in the wrong file, and
even if you disagree and think this is the right file. it's not done exactly
right.