[webkit-reviews] review requested: [Bug 21816] Clean up ImageBuffer.h so there do not have to be separate ifdefs for each platform : [Attachment 24624] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 23 15:41:46 PDT 2008


Brett Wilson (Google) <brettw at chromium.org> has asked  for review:
Bug 21816: Clean up ImageBuffer.h so there do not have to be separate ifdefs
for each platform
https://bugs.webkit.org/show_bug.cgi?id=21816

Attachment 24624: Patch v2
https://bugs.webkit.org/attachment.cgi?id=24624&action=edit

------- Additional Comments from Brett Wilson (Google) <brettw at chromium.org>
This adds a flag to ImageBuffer that create can use to check if it should
return true or not. This has the nice effect of making create() cross-platform,
so I moved it into the header file. I think the platform-specific code is also
more clear as a result, you just have to set the flag properly and you don't
have to worry about writing create and returning an enpty auto_ptr.

I left IntSize passed by reference for consistency. I can still change all uses
of IntPoint in this class to by-value instead, but that seems less consistent
with the rest of the project to me.


More information about the webkit-reviews mailing list