[webkit-reviews] review denied: [Bug 3402] onUnload event doesn't fire : [Attachment 21025] Initial patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 24 23:10:08 PDT 2008

Darin Adler <darin at apple.com> has denied Rob Buis <rwlbuis at gmail.com>'s request
for review:
Bug 3402: onUnload event doesn't fire

Attachment 21025: Initial patch

------- Additional Comments from Darin Adler <darin at apple.com>
The patch needs a test case for each of the events you're patching here; and we
need to double check with other browsers behavior too.

Also, I don't think this is the correct approach. I don't think we want to add
these listeners to both the body element and the window object. Instead we want
to dispatch these events to both the window object and the body element.

More information about the webkit-reviews mailing list