[webkit-reviews] review denied: [Bug 18971] Crash on sierpinski svg : [Attachment 21053] First attempt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 24 23:08:13 PDT 2008

Darin Adler <darin at apple.com> has denied Rob Buis <rwlbuis at gmail.com>'s request
for review:
Bug 18971: Crash on sierpinski svg

Attachment 21053: First attempt

------- Additional Comments from Darin Adler <darin at apple.com>
+	     Node *cloneParentPtr = cloneParent.get();

There's no guaranteed that this node won't go away due to DOM mutation code.
The local variable needs to be a RefPtr. And the result needs to be a
PassRefPtr<Node>, not a raw Node* pointer.

The test case should be included in the patch, too.

More information about the webkit-reviews mailing list