[webkit-reviews] review denied: [Bug 16362] Incorrect implementation of 'ex' unit : [Attachment 21015] patch (updated)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 24 23:14:01 PDT 2008


Darin Adler <darin at apple.com> has denied Anatoli Papirovski
<apapirovski at mac.com>'s request for review:
Bug 16362: Incorrect implementation of	'ex' unit
http://bugs.webkit.org/show_bug.cgi?id=16362

Attachment 21015: patch (updated)
http://bugs.webkit.org/attachment.cgi?id=21015&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Thanks for tackling this.

I'd like Hyatt to weigh in with his opinion about this.

As with any other bug fix, we need a regression test case in the patch, and the
patch also needs to include updates to the results of any existing test cases
affected by the change.

Setting review- because of the lack of a test case for now. Please make a new
patch that includes a test case as well as any changes to the expected results
of existing test cases.


More information about the webkit-reviews mailing list