[webkit-reviews] review denied: [Bug 17139] Add support for height property on <tbody> element : [Attachment 21071] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 24 23:06:53 PDT 2008

Darin Adler <darin at apple.com> has denied Vincent Ricard
<magic at magicninja.org>'s request for review:
Bug 17139: Add support for height property on <tbody> element

Attachment 21071: Patch

------- Additional Comments from Darin Adler <darin at apple.com>
This seems wrong. It assumes that the height of the <tbody> can be evenly
divided by the number of rows. That's clearly not correct when some rows have
explicit heights themselves. For example, consider a <tbody> with a height of
100px, containing five rows where the first four rows all are 10px tall. It
doesn't make sense to have the fifth row by 20px tall. It should be 60px tall.

We'll need more than one test case for this, too. The test patch needs to
include the expected results for the test case. Does this change affect the
results of any other test cases? I'd be amazed if it didn't affect any of the
hundreds of table test cases we imported from the Mozilla project.

I want to hear Hyatt's take on this too. What is the correct behavior for table

More information about the webkit-reviews mailing list