[webkit-reviews] review granted: [Bug 17898] Split PluginMessageThrottlerWin into its own files : [Attachment 19844] Patch to split PluginMessageThrottlerWin from PluginViewWin.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 17 13:03:34 PDT 2008


Adam Roben (aroben) <aroben at apple.com> has granted Rodney Dawes
<dobey at wayofthemonkey.com>'s request for review:
Bug 17898: Split PluginMessageThrottlerWin into its own files
http://bugs.webkit.org/show_bug.cgi?id=17898

Attachment 19844: Patch to split PluginMessageThrottlerWin from
PluginViewWin.cpp
http://bugs.webkit.org/attachment.cgi?id=19844&action=edit

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
+++ WebCore/plugins/PluginView.h	(working copy)
@@ -34,6 +34,7 @@
 #include "IntRect.h"
 #include "KURL.h"
 #include "PlatformString.h"
+#include "PluginMessageThrottlerWin.h"
 #include "PluginStream.h"
 #include "ResourceRequest.h"
 #include "Timer.h"
@@ -59,7 +60,6 @@ namespace WebCore {
     class KeyboardEvent;
     class MouseEvent;
     class KURL;
-    class PluginMessageThrottlerWin;
     class PluginPackage;
     class PluginRequest;
     class PluginStream;

This change should not be necessary for just moving the class into its own
files.

PluginView.h should not change in this patch.

+#ifndef PluginMessageThrottlerWin_H

That should be a lowercase "h" at the end of the macro.

I'll fix the above two issues when landing this patch.


More information about the webkit-reviews mailing list