[webkit-reviews] review requested: [Bug 17837] Separate Windows Networking into CFNetwork and Curl Files : [Attachment 19845] Revision 3 based on aroben's further comments.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 17 12:52:25 PDT 2008


Brent Fulgham <bfulgham at gmail.com> has asked  for review:
Bug 17837: Separate Windows Networking into CFNetwork and Curl Files
http://bugs.webkit.org/show_bug.cgi?id=17837

Attachment 19845: Revision 3 based on aroben's further comments.
http://bugs.webkit.org/attachment.cgi?id=19845&action=edit

------- Additional Comments from Brent Fulgham <bfulgham at gmail.com>
* Removed unused constructor from curl/AuthenticationChallenge.h
* However:  Retained implementation of get and member variable so that normal
use of AuthenticationChallenge object does not have to be commented out for
Curl case.  This will eventually be used for 'real stuff'.
* Cleaned up formatting.
* Removed some unneeded "wtf/RetainPtr" includes.


More information about the webkit-reviews mailing list