[webkit-reviews] review requested: [Bug 17754] [Curl] Implement ResourceHandle::loadResourceSynchronously : [Attachment 19846] Updated patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <julien.chaffraix at gmail.com> has asked  for review:
Bug 17754: [Curl] Implement ResourceHandle::loadResourceSynchronously
http://bugs.webkit.org/show_bug.cgi?id=17754

Attachment 19846: Updated patch
http://bugs.webkit.org/attachment.cgi?id=19846&action=edit

------- Additional Comments from Julien Chaffraix <julien.chaffraix at gmail.com>
> IIRC the URL should be in plain ASCII with special characters escaped with
%XX.
> If it is the case, there does not seem to be any appropriate encoder /
decoder.
> It should be quite easy to add one (that could be shared somewhere else).

Forget that part : the KURL constructor already escapes characters.

> You might want to fix the encoding of m_url (or convince me why url.latin1()
is
> always correct) and then update your ResourceError line and then land your
> patch.
> 

I did some testing and the encoding seems right mainly due to the KURL
constructor's escaping as mentioned above. Thus calling latin1() is only a way
of having a char* (no character translation occurs in latin1() as the string is
already in ASCII).