[webkit-reviews] review cancelled: [Bug 20099] [GTK] SHIFT+PAGE_UP/DOWN doesn't extend selection : [Attachment 22374] Trivial patch changing call to frame->selection()->modify instead of frame->editor()->command

[bugzilla-daemon at webkit.org]

Adrien Nader <camaradetux at gmail.com> has cancelled Adrien Nader
<camaradetux at gmail.com>'s request for review:
Bug 20099: [GTK] SHIFT+PAGE_UP/DOWN doesn't extend selection
https://bugs.webkit.org/show_bug.cgi?id=20099

Attachment 22374: Trivial patch changing call to frame->selection()->modify
instead of frame->editor()->command
https://bugs.webkit.org/attachment.cgi?id=22374&action=edit

------- Additional Comments from Adrien Nader <camaradetux at gmail.com>
The granulariy is now correct. The proper thing was already available but I was
not aware of its existence. The patch is also simpler.

Basically this patch changes
  "MovePageUp"
to
  kevent->shiftKey() ? "MovePageUpAndModifySelection" : "MovePageUp"