[webkit-reviews] review requested: [Bug 20099] [GTK] SHIFT+PAGE_UP/DOWN doesn't extend selection : [Attachment 22431] new version with the proper granularity (simpler btw)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 22 10:49:00 PDT 2008

Adrien Nader <camaradetux at gmail.com> has asked	for review:
Bug 20099: [GTK] SHIFT+PAGE_UP/DOWN doesn't extend selection

Attachment 22431: new version with the proper granularity (simpler btw)

------- Additional Comments from Adrien Nader <camaradetux at gmail.com>
The granulariy is now correct. The proper thing was already available but I was
not aware of its existence. The patch is also simpler.

Basically this patch changes
  kevent->shiftKey() ? "MovePageUpAndModifySelection" : "MovePageUp"

More information about the webkit-reviews mailing list