[webkit-reviews] review granted: [Bug 19377] REGRESSION (r34109): "Inspect Element" on a node in a subframe doesn't highlight that node : [Attachment 22430] Proposed patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 19377: REGRESSION (r34109): "Inspect Element" on a node in a subframe
doesn't highlight that node
https://bugs.webkit.org/show_bug.cgi?id=19377

Attachment 22430: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=22430&action=edit

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
"sameObjects" is a somewhat awkward name for an equality function. I think it
needs some version of "to be" in it, like "areSameObject" or "objectsAreSame"
or "objectsAreEqual". It also seems like we might as well call up to C++ to do
the comparison on the unwrapped objects for real, if we're sending everything
through a single bottleneck anyway.

r=me, but do consider renaming sameObjects.