[webkit-reviews] review requested: [Bug 19588] CRASH doing open() on destroyed window : [Attachment 22432] Updated version: use top() and cover the other crash pointed by Eric

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has asked  for review:
Bug 19588: CRASH doing open() on destroyed window
https://bugs.webkit.org/show_bug.cgi?id=19588

Attachment 22432: Updated version: use top() and cover the other crash pointed
by Eric
https://bugs.webkit.org/attachment.cgi?id=22432&action=edit

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
> Why shouldn't you just use "top()" here?  It seems "top()" wouldn't crash.

top() is indeed fine.

> Seems like the end of the function doesn't check against null pages either...

> so that will need to be fixed and a test case added too.

True, I have fixed that too including a layout test.