[webkit-reviews] review denied: [Bug 17042] <form> tags used
without action attribute but with a <base> tag : [Attachment
18741] Patch using FF and IE implementation
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 30 12:46:26 PST 2008
Darin Adler <darin at apple.com> has denied Robert Sesek <rsesek at bluestatic.org>'s
request for review:
Bug 17042: <form> tags used without action attribute but with a <base> tag
http://bugs.webkit.org/show_bug.cgi?id=17042
Attachment 18741: Patch using FF and IE implementation
http://bugs.webkit.org/attachment.cgi?id=18741&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
Thanks for contributing this fix!
The code change looks OK to me, but we need a regression test. That's the
policy for the WebKit project -- we require a test for any bug we fix.
The LayoutTests/fast/forms directory has lots of form tests. You can probably
start with one of those to make a test. For example, empty-get.html.
More information about the webkit-reviews
mailing list