[webkit-reviews] review denied: [Bug 14270] Impossible to close web inspector when docked to webview : [Attachment 18795] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 30 12:06:11 PST 2008

Adam Roben <aroben at apple.com> has denied Matt Lilek <webkit at mattlilek.com>'s
request for review:
Bug 14270: Impossible to close web inspector when docked to webview

Attachment 18795: patch

------- Additional Comments from Adam Roben <aroben at apple.com>
+	 { "attachedClose", attachedClose, kJSPropertyAttributeNone },

Maybe "hide" would be a better name for this method?

I think the Windows code could be better factored to share more code between
closeWindow and closeAttachedWindow. It also seems strange to have to call
ShowWindow(SW_HIDE) in closeAttachedWindow() -- won't th window already be

Is there any flashing when m_attachOnShow is true? I'd expect to see the
detached window appear, then disappear given the way the code is written.

Any chance we could see some screenshots of the new close button in action?

More information about the webkit-reviews mailing list