[webkit-reviews] review requested: [Bug 17066] [GTK] Improve frameloader signals : [Attachment 18763] Improve load signals

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 29 07:54:32 PST 2008

Christian Dywan <christian at imendio.com> has asked  for review:
Bug 17066: [GTK] Improve frameloader signals

Attachment 18763: Improve load signals

------- Additional Comments from Christian Dywan <christian at imendio.com>
This is a suggestion for improving the above mentioned issues.

This patch makes names all signals consistently, emits 'load-done' on the
WebView, passes a WebKitEventLoad* structure to each signal and reports errors
with a GError*.

Note that this does not address missing error reporting in the http backend.

I am not fully decided myself on whether this specific patch is what we want,
particularly I'm concerned with 'load-progress-changed' and critique is very

More information about the webkit-reviews mailing list