[webkit-reviews] review cancelled: [Bug 16979] Patch to conditionalize some CG/Cairo support in win32 : [Attachment 18740] Fourth revision based on Adam's comments.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 29 12:27:09 PST 2008


Brent Fulgham <bfulgham at gmail.com> has cancelled Brent Fulgham
<bfulgham at gmail.com>'s request for review:
Bug 16979: Patch to conditionalize some CG/Cairo support in win32
http://bugs.webkit.org/show_bug.cgi?id=16979

Attachment 18740: Fourth revision based on Adam's comments.
http://bugs.webkit.org/attachment.cgi?id=18740&action=edit

------- Additional Comments from Brent Fulgham <bfulgham at gmail.com>
- Better use of 'float' declarations.
- Change C-style casts to static_cast
- Remove commented-out code
- Rename "getShouldApplyMacAscentHack" to "shouldApplyMacAscentHack"
- Correct brace position on some if statements


More information about the webkit-reviews mailing list