[webkit-reviews] review denied: [Bug 16994] SmartReplace.cpp isn't implemented for platforms without CoreFoundation : [Attachment 18752] take 2

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied idealisms at gmail.com's request for
review:
Bug 16994: SmartReplace.cpp isn't implemented for platforms without
CoreFoundation
http://bugs.webkit.org/show_bug.cgi?id=16994

Attachment 18752: take 2
http://bugs.webkit.org/attachment.cgi?id=18752&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+#ifdef USE(ICU_UNICODE)

That's incorrect. It needs to be:

#if USE(ICU_UNICODE)

And the ICU version should really be in a different file, as the CF version is.


review- because of the ifdef/if issue.