[webkit-reviews] review granted: [Bug 16778] Language specific bindings cannot cache/reuse previously created Instances and RuntimeObjects : [Attachment 18337] Updated patch - better Qt RuntimeObjectImp lifetime management

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 10 16:24:03 PST 2008


Anders Carlsson <andersca at apple.com> has granted Michael Goddard
<michael.goddard at trolltech.com>'s request for review:
Bug 16778: Language specific bindings cannot cache/reuse previously created
Instances and RuntimeObjects
http://bugs.webkit.org/show_bug.cgi?id=16778

Attachment 18337: Updated patch - better Qt RuntimeObjectImp lifetime
management
http://bugs.webkit.org/attachment.cgi?id=18337&action=edit

------- Additional Comments from Anders Carlsson <andersca at apple.com>
>+    virtual BindingLanguage getBindingLanguage() const {return CLanguage;}

Need spaces after the open brace and before the close brace.

>+    virtual BindingLanguage getBindingLanguage() const {return JavaLanguage;}


Here too.

>+    virtual BindingLanguage getBindingLanguage() const {return
ObjectiveCLanguage;}

Here too.

>+    virtual BindingLanguage getBindingLanguage() const {return QtLanguage;}

And here :)

This looks great otherwise, r=me.


More information about the webkit-reviews mailing list