[webkit-reviews] review granted: [Bug 16779] Make the PluginStream implementation be shared across platforms : [Attachment 18370] Updated patch to fix WebCore.pro and preserve history for the PluginStream code

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Rodney Dawes
<dobey at wayofthemonkey.com>'s request for review:
Bug 16779: Make the PluginStream implementation be shared across platforms
http://bugs.webkit.org/show_bug.cgi?id=16779

Attachment 18370: Updated patch to fix WebCore.pro and preserve history for the
PluginStream code
http://bugs.webkit.org/attachment.cgi?id=18370&action=edit

------- Additional Comments from Anders Carlsson <andersca at apple.com>
+CString openTempFileHandle(const char* prefix, PlatformFileHandle& handle);
+void closeTempFileHandle(PlatformFileHandle& handle);
+int writeToTempFileHandle(PlatformFileHandle handle, const char* data, int
length);

I would prefer if "Handle" could be omitted from these functions (and maybe
even "Temp"). Looks great otherwise. Thanks for working on this!