[webkit-reviews] review granted: [Bug 16818] dftables should be rewritten as a script : [Attachment 18377] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 10 15:06:01 PST 2008

Darin Adler <darin at apple.com> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 16818: dftables should be rewritten as a script

Attachment 18377: Patch v1

------- Additional Comments from Darin Adler <darin at apple.com>
+    $(JavaScriptCore)/pcre

Should have a backslash at the end of this line, or you could delete the "#" at
the beginning of the next line which is supposed to be a sort of reminder that
you're at the end of the script.

Looks fine, r=me

(Too bad I have saved patches with changes to the tool -- should be easy enough
to port, though.)

More information about the webkit-reviews mailing list