[webkit-reviews] review denied: [Bug 17373] Language code in User-Agent header doesn't support 3- or 4-letter language codes : [Attachment 19136] Proposed patch, v1.0

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Nicholas Shanks
<contact at nickshanks.com>'s request for review:
Bug 17373: Language code in User-Agent header doesn't support 3- or 4-letter
language codes
http://bugs.webkit.org/show_bug.cgi?id=17373

Attachment 19136: Proposed patch, v1.0
http://bugs.webkit.org/attachment.cgi?id=19136&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Seems OK. What are some actual language codes we can test this with. Do we know
what this does to website compatibility?

No change log.

No regression tests. Need to find a way to regression-test this.

Formatting does not match style guide: single line if statements should not
have braces.

Fix seems fine with some minor problems. Benefit also seems small unless
there's some actual language code that's going to come up in practice, so
setting to review- to get the minor problems fixed.