[webkit-reviews] review granted: [Bug 17411] Ideographic comma and full stop should be treated as line-breakable characters : [Attachment 19179] Revised patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Satoshi Nakagawa
<artension at gmail.com>'s request for review:
Bug 17411: Ideographic comma and full stop should be treated as line-breakable
characters
http://bugs.webkit.org/show_bug.cgi?id=17411

Attachment 19179: Revised patch
http://bugs.webkit.org/attachment.cgi?id=19179&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Should this be fixed in ICU rather than in WebKit? We're using the ICU ubrk.h
header for this, using UBRK_LINE. Why doesn't it say these characters should be
breaks?

The switch statement in break_lines.cpp is *only* to work around bugs in ICU's
ubrk.h or to implement rules that don't make sense at the ICU level but are
needed for a web browser.

I'll tentatively agree that we should land this patch, but I'm not sure why ICU
doesn't already handle this properly.

r=me