[webkit-reviews] review granted: [Bug 14348] Messing up the inspector by dragging an URL into it : [Attachment 19217] implement drag destination delegate

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 20 09:22:12 PST 2008


Darin Adler <darin at apple.com> has granted Matt Lilek <webkit at mattlilek.com>'s
request for review:
Bug 14348: Messing up the inspector by dragging an URL into it
http://bugs.webkit.org/show_bug.cgi?id=14348

Attachment 19217: implement drag destination delegate
http://bugs.webkit.org/attachment.cgi?id=19217&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks good.

+	 * ChangeLog:

Should not be in there.

+#ifndef WebInspectorBaseDelegate_H

Should be _h, not _H.

+    // COM ref-counting isn't useful to us because we're in charge of the
lifetime of the WebView.

Are you sure this is OK?

r=me


More information about the webkit-reviews mailing list