[webkit-reviews] review requested: [Bug 22683] Improper calls to checkArgv function : [Attachment 25776] Fix of function calls

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 5 10:40:38 PST 2008


Zan Dobersek <zandobersek at gmail.com> has asked	for review:
Bug 22683: Improper calls to checkArgv function
https://bugs.webkit.org/show_bug.cgi?id=22683

Attachment 25776: Fix of function calls
https://bugs.webkit.org/attachment.cgi?id=25776&action=review

------- Additional Comments from Zan Dobersek <zandobersek at gmail.com>
Fixed function calls

To explain a bit further, in the checkArgv function, shift is called twice on
the arguments array. If the second shift fails, the argument we search for is
not removed from the arguments array. Since it is not removed, scripts exit
with a complain, for instance, that the "--gtk" is an unknown option.

This fixes such problems on the Gtk+ port, but I am unsure if this behaviour is
acceptable on others.


More information about the webkit-reviews mailing list