[webkit-reviews] review denied: [Bug 22683] Improper calls to checkArgv function : [Attachment 25776] Fix of function calls

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 5 10:53:30 PST 2008

Eric Seidel <eric at webkit.org> has denied Zan Dobersek <zandobersek at gmail.com>'s
request for review:
Bug 22683: Improper calls to checkArgv function

Attachment 25776: Fix of function calls

------- Additional Comments from Eric Seidel <eric at webkit.org>
I intentionally changed this to fix run-javascriptcore-tests --gtk, etc. to
pass --gtk along to build-jsc.

Obviously we need a better solution which handles both cases.

Which scripts are being passed an unfiltered @ARGV in the gtk port?

We could have a global flag controlling this, or we could go back to always
removing them from @ARGV (like your patch does) and add a configurationFlags()
function which knows how to produce "--debug --gtk", etc. for passing to

I'd be interested in your thoughts?

More information about the webkit-reviews mailing list