[webkit-reviews] review granted: [Bug 20013] Windows AX heuristics are poor : [Attachment 22822] Patch to populate the name attribute for Image Elements

[bugzilla-daemon at webkit.org]

Jon Honeycutt <jhoneycutt at apple.com> has granted Eric Seidel
<eric at webkit.org>'s request for review:
Bug 20013: Windows AX heuristics are poor
https://bugs.webkit.org/show_bug.cgi?id=20013

Attachment 22822: Patch to populate the name attribute for Image Elements
https://bugs.webkit.org/attachment.cgi?id=22822&action=edit

------- Additional Comments from Jon Honeycutt <jhoneycutt at apple.com>
Eric is correct that we should respect the title attribute for image elements.
Firefox 3 falls back to the title attribute if it doesn't find an alt
attribute.

Firefox respects the title attribute for many other elements, though, so I
think that should be considered a separate bug.

Firefox also ignores the alt attribute on objects that aren't native images,
but I believe that's a bug.

This change seems good to me, but I think a layout test that tests that both
native images and objects with role="img" have their alternative text exposed.

r=me, but please add a test.