[webkit-reviews] review denied: [Bug 20013] Windows AX heuristics are poor : [Attachment 22825] Patch to populate name attribute for links and headings.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 21 22:38:08 PDT 2008


Jon Honeycutt <jhoneycutt at apple.com> has denied Sankar Aditya Tanguturi
<sankaraditya+bugzilla at gmail.com>'s request for review:
Bug 20013: Windows AX heuristics are poor
https://bugs.webkit.org/show_bug.cgi?id=20013

Attachment 22825: Patch to populate name attribute for links and headings.
https://bugs.webkit.org/attachment.cgi?id=22825&action=edit

------- Additional Comments from Jon Honeycutt <jhoneycutt at apple.com>
+	 Populate Name attribute for links and Headins appropriately.
Typos: Name, Headings shouldn't be capitalized, and headings is missing a g.

This change looks fine, but it requires that your "Patch to populate Name
attribue for Text Elements" be applied to test, so I think you should combine
the two patches.

r- for that, and please add layout tests.

Thanks!


More information about the webkit-reviews mailing list