[webkit-reviews] review denied: [Bug 20013] Windows AX heuristics are poor : [Attachment 22820] Patch to populate the role attribute for list elements.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 21 22:19:12 PDT 2008


Jon Honeycutt <jhoneycutt at apple.com> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 20013: Windows AX heuristics are poor
https://bugs.webkit.org/show_bug.cgi?id=20013

Attachment 22820: Patch to populate the role attribute for list elements.
https://bugs.webkit.org/attachment.cgi?id=22820&action=edit

------- Additional Comments from Jon Honeycutt <jhoneycutt at apple.com>
The change looks right, but without the change to expose list elements from
your "Patch to expose only Relavant Accessible Objects ", it can't be verified
in an accessibility tool that this patch works as expected.

I think you should create a "patch to properly expose list elements" patch that
exposes list elements, returns the correct role, and includes a short layout
test.

Thanks! r-, but the behavior looks correct.


More information about the webkit-reviews mailing list