[webkit-reviews] review granted: [Bug 18488] FastMalloc doesn't release thread-specific data on Windows : [Attachment 20529] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 14 08:59:56 PDT 2008


Adam Roben (aroben) <aroben at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 18488: FastMalloc doesn't release thread-specific data on Windows
http://bugs.webkit.org/show_bug.cgi?id=18488

Attachment 20529: proposed fix
http://bugs.webkit.org/attachment.cgi?id=20529&action=edit

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
+#include <process.h>
 #include "MainThread.h"
 #include <windows.h>
 #include <wtf/HashMap.h>
 #include <wtf/MathExtras.h>

I think process.h should be moved below MainThread.h

+unsigned __stdcall wtfThreadEntryPoint(void* param)

I think this should be declared static.

r=me


More information about the webkit-reviews mailing list