[webkit-reviews] review denied: [Bug 18435] Cairo build does not work as it is in the tree : [Attachment 20487] fix for Cairo build

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 14 09:04:27 PDT 2008

Adam Roben (aroben) <aroben at apple.com> has denied Daniel Zucker
<zucker at wake3.com>'s request for review:
Bug 18435: Cairo build does not work as it is in the tree

Attachment 20487: fix for Cairo build

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
This patch seems to use tabs for indentation. Please only use 4 spaces for

@@ -1665,6 +1666,7 @@ HRESULT STDMETHODCALLTYPE WebFrame::spoo
     /* [in] */ UINT endPage,
     /* [retval][out] */ void* ctx)
     if (!printDC || !ctx) {
	 return E_POINTER;
@@ -1748,8 +1750,11 @@ HRESULT STDMETHODCALLTYPE WebFrame::spoo
     return S_OK;
+	notImplemented();
+	return E_NOTIMPL;
+#endif //!PLATFORM(CAIRO)

Can we move most of spoolPages down into WebCore? You should talk to Alp Toker,
who I think was working on a cross-platform printing abstraction.

 void DrawTextAtPoint(CGContextRef cgContext, LPCTSTR text, int length, POINT
point, const WebFontDescription& description, CGColorRef color, int
underlinedIndex, bool drawAsPassword)
     GraphicsContext context(cgContext);
     String drawString(text, length);
     if (drawAsPassword)
	 drawString = drawString.impl()->secure(WebCore::bullet);
     WebCoreDrawTextAtPoint(context, drawString, point, makeFont(description),
color, underlinedIndex);
+	notImplemented();
+#endif //!Platform(CAIRO)

Seems like this whole function will have to be compiled out for Cairo, since
you won't have a CGContextRef type.

I think we can/should rework WebDragClient to use the new ImageBuffer
abstraction so that we can remove the CG-specific code from it.

More information about the webkit-reviews mailing list