[webkit-reviews] review requested: [Bug 14898] XMLHttpRequest.getAllResponseHeaders should separate headers with CRLF : [Attachment 16462] Modified patches

[bugzilla-daemon at webkit.org]

Julien Chaffraix <julien.chaffraix at gmail.com> has asked  for review:
Bug 14898: XMLHttpRequest.getAllResponseHeaders should separate headers with
CRLF
http://bugs.webkit.org/show_bug.cgi?id=14898

Attachment 16462: Modified patches
http://bugs.webkit.org/attachment.cgi?id=16462&action=edit

------- Additional Comments from Julien Chaffraix <julien.chaffraix at gmail.com>
> Wouldn't UChar('\r'), UChar('\n') work just as well, and be slightly clearer?


Yes, totally true. I have updated that part.

> Please include a regression test with your code change.

The regression test is attached that should validate the patch. The problem is
I cannot get the results on my platform due to the lack of ResourceResponse on
Qt (merely getAllResponseHeaders returns an empty string).