[webkit-reviews] review denied: [Bug 15055] Divide by 0 in ProgressTracker::incrementProgress : [Attachment 16204] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 29 20:22:08 PDT 2007

Maciej Stachowiak <mjs at apple.com> has denied Marvin Decker
<marv.decker at gmail.com>'s request for review:
Bug 15055: Divide by 0 in ProgressTracker::incrementProgress

Attachment 16204: Patch

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
The fix looks good to me (I can understand why the remainingBytes estimate
could be wrong, since resources might not specify their length). But do you
have a test case that can trigger this? I believe it could be done as an http
test. r- to consider providing a test case, but if that is not practical just
reflag for review and I'll approve it.

More information about the webkit-reviews mailing list