[webkit-reviews] review denied: [Bug 12988] First element (in document order) is not returned when other duplicate ID-ed elements were created first : [Attachment 16197] newer version of Rob's patch, improved a bit more

[bugzilla-daemon at webkit.org]

Adam Roben <aroben at apple.com> has denied 's request for review:
Bug 12988: First element (in document order) is not returned when other
duplicate ID-ed elements were created first
http://bugs.webkit.org/show_bug.cgi?id=12988

Attachment 16197: newer version of Rob's patch, improved a bit more
http://bugs.webkit.org/attachment.cgi?id=16197&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
Somehow, duplicate-ids-document-order.html got put in the patch twice, and
duplicate-ids-document-order-expected.txt is missing.

+    // excluding the one referenced in m_elementsById, if any. This means it
one less than the total count

Typo: it one -> it is one

+    div = document.createElement ('div');

There's an extra space before the open parenthesis.

r- until the test results are added, then I'll r+ for feature-branch.