[webkit-reviews] review denied: [Bug 15254] [gtk] implement theme-aware drawing of text field or text area : [Attachment 16344] implement theme-aware drawing of text fields and text area

[bugzilla-daemon at webkit.org]

Adam Roben <aroben at apple.com> has denied Jan Alonzo <jmalonzo at gmail.com>'s
request for review:
Bug 15254: [gtk] implement theme-aware drawing of text field or text area
http://bugs.webkit.org/show_bug.cgi?id=15254

Attachment 16344: implement theme-aware drawing of text fields and text area
http://bugs.webkit.org/attachment.cgi?id=16344&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
+    else if (isChecked(o))
+	 result = GTK_STATE_SELECTED;

Is this really needed for drawing text fields? Or is this just something that
was missing and you added it while you were touching the code?

+    gtk_paint_shadow(entry->style, i.context->gdkDrawable(),
+		      determineState(o), determineShadow(o),
+		      NULL, entry, "entry",
+		      pos.x(), pos.y(), rect.width(), rect.height());

Since this is C++ code, please use 0 instead of NULL.

+    if (GTK_WIDGET_HAS_FOCUS(entry))
+    {

As per <http://webkit.org/coding/coding-style.html>, please pur the brace on
the same line as the if.

r- so the above can be fixed. Once that's done I'll r+ it.