[webkit-reviews] review denied: [Bug 15236] RenderTheme forces borders for MenulistButtonAppearance : [Attachment 16318] make some methods virtual

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 22 13:37:55 PDT 2007

Adam Roben <aroben at apple.com> has denied Matt Perry <mpComplete at gmail.com>'s
request for review:
Bug 15236: RenderTheme forces borders for MenulistButtonAppearance

Attachment 16318: make some methods virtual

------- Additional Comments from Adam Roben <aroben at apple.com>
I don't think this is the right way to go about this. If this change were made,
the <select>s computedStyle would still include the border-radius properties,
even though we wouldn't be honoring them. Instead, you should override
adjustMenuListButtonStyle, which is already virtual.

More information about the webkit-reviews mailing list