[webkit-reviews] review denied: [Bug 15255] GTK+ WebKit should allow the application to execute Javascript on it. : [Attachment 16347] Call Javascript from gtkwebkitpage

[bugzilla-daemon at webkit.org]

Adam Roben <aroben at apple.com> has denied Sean Egan <seanegan at gmail.com>'s
request for review:
Bug 15255: GTK+ WebKit should allow the application to execute Javascript on
it.
http://bugs.webkit.org/show_bug.cgi?id=15255

Attachment 16347: Call Javascript from gtkwebkitpage
http://bugs.webkit.org/attachment.cgi?id=16347&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
As per <http://webkit.org/coding/coding-style.html>, please put asterisks next
to the type name, not the variable name.

+    if (FrameLoader *loader = frameData->frame->loader())
+	 loader->executeScript(script, true);
+	
+}

Looks like you've got an extra line of whitespace after the if statement.

I also think it would make more sense for this API to be on WebKitGtkFrame,
rather than having it implicitly operate on the main frame.

r- for now so that the above changes can be made, but I definitely agree this
is a useful API to have!