[webkit-reviews] review denied: [Bug 15057] EditorClientGtk is missing some important keypress handling, patch attached : [Attachment 16102] updated patch based on suggestions, also changed characters to keycodes

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Jasper Bryant-Greene <m at ni.ac.nz>'s
request for review:
Bug 15057: EditorClientGtk is missing some important keypress handling, patch
attached
http://bugs.webkit.org/show_bug.cgi?id=15057

Attachment 16102: updated patch based on suggestions, also changed characters
to keycodes
http://bugs.webkit.org/attachment.cgi?id=16102&action=edit

------- Additional Comments from Oliver Hunt <oliver at apple.com>
This causes a build failure on mac as KeyboardCodes.h does not exist on mac. 
This can be fixed by an ifdef around the include

Mac also fails due due selectionForEvent not being available in EditorMac -- i
suspect moving the Mac impl of Editor::handleKeypress into an ifdef'd block in
Editor.cpp, or remove the static modifier in Editor.cpp

On windows KeyboardCodes.h does not exit (ifdef fix again), and WebEditorClient
requires interpretKeyEvent -- which might be difficult to work around...
perhaps make it accesible from outside webcore? :-/