[webkit-reviews] review requested: [Bug 15057] EditorClientGtk is missing some important keypress handling, patch attached : [Attachment 16103] (should have) fixed build failures on windows and mac

[bugzilla-daemon at webkit.org]

Jasper Bryant-Greene <m at ni.ac.nz> has asked  for review:
Bug 15057: EditorClientGtk is missing some important keypress handling, patch
attached
http://bugs.webkit.org/show_bug.cgi?id=15057

Attachment 16103: (should have) fixed build failures on windows and mac
http://bugs.webkit.org/attachment.cgi?id=16103&action=edit

------- Additional Comments from Jasper Bryant-Greene <m at ni.ac.nz>
I've made selectionForEvent non-static and put a prototype in EditorMac.mm.

commandForKeyEvent is now a static member of Editor.

KeyboardCodes.h has been surrounded with #if !PLATFORM(MAC) && !PLATFORM(WIN)
... #endif, however this file is identical on GTK/Qt/WX and so I will submit a
subsequent patch to resolve this duplication.